Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Form Templates now offer basic developer template #83

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Form Templates now offer basic developer template #83

merged 11 commits into from
Nov 8, 2022

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Nov 7, 2022 •
edited
Loading

Description

This PR adds a basic developer template, which at this time is the Classic Template with some opinionated styles removed.

This PR also localizes a list of templates for selection in the form builder.

Affects

  • Moves the AmountField template from the Classic template into the framework

Visuals

image

Testing Instructions

The new developer template can be viewed in the Design Preview.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@kjohnson kjohnson changed the title Form Templates now offer basic markup template Form Templates now offer basic developer template Nov 7, 2022
@kjohnson kjohnson marked this pull request as ready for review November 7, 2022 21:16
@kjohnson kjohnson requested a review from jonwaldstein November 7, 2022 21:16
jonwaldstein
jonwaldstein suggested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, but great job overall. Nice to see how easy spinning up a template is.

@kjohnson kjohnson requested a review from jonwaldstein November 8, 2022 17:12
This was referenced Nov 8, 2022
Closed
Open
jonwaldstein
jonwaldstein approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@kjohnson kjohnson merged commit b00eeb3 into develop Nov 8, 2022
@jonwaldstein jonwaldstein deleted the feature/basic-markup-template branch November 8, 2022 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonwaldstein jonwaldstein jonwaldstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjohnson @jonwaldstein