Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Custom fields can now be toggled to store as donor meta #69

Merged
merged 15 commits into from
Oct 4, 2022

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Sep 30, 2022

Depends on #65

Description

This PR adds a toggle setting to fields for choosing the location of storage labeled "store as donor meta".

Affects

Will eventually affect field persistence.

Visuals

Screen Shot 2022-10-04 at 11 21 38 AM

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@github-actions
Copy link

A build of this branch is available at https://impress-org.github.io/givewp-next-gen/kbj/custom-fields-store-as

@jonwaldstein jonwaldstein marked this pull request as ready for review October 4, 2022 15:23
@jonwaldstein jonwaldstein self-requested a review October 4, 2022 15:35
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I just moved the toggle below the field name and added some help text for more context.

@jonwaldstein jonwaldstein merged commit 95bd8c7 into develop Oct 4, 2022
@jonwaldstein jonwaldstein deleted the kbj/custom-fields-store-as branch October 4, 2022 15:37
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants