This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
Feature: Add Payment Gateways block and make section act normal #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjohnson
suggested changes
Aug 17, 2022
|
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/feature/improve-payments-section |
kjohnson
approved these changes
Aug 17, 2022
|
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Up to this point the "payment details" section was special. It didn't actually conform to what the Form Builder did, as it was uniquely identified and rendered in the form code. In part, this was because there was no Payment Gateway block.
This PR introduces the Payment Gateway block and template, and normalizes how the section functions. Very likely we'll want to adjust how the template works in the future, as it currently relies on hooks that make it hard to override, but this is good enough for now. It's more important to get the section working normally so there isn't a disconnect between itself and the Form Builder.
We are still adding a couple hidden fields to that section. We'll want to move these at some point and determine where/how we'd like to add those critical fields.
Lastly, I took a moment to clean up some Classic template styles and make the Donation Summary look more like the original design.
Affects
The payment details section as a whole, really. Also, stylistically, I tweaked all sections for the Classic template to improve spacing between fields.
Visuals
Testing Instructions
Check that adding fields to the payments section now works, as well as moving things around.
Pre-review Checklist
@unreleasedtags included in DocBlocks