Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: add company field persistence to next-gen form #50

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Aug 4, 2022

Description

This adds persistence support for the company field on the next-gen donation form. Since there is currently no option to specify if the field is required right now in the form-builder, we'll assume it's optional until we add that functionality.

Affects

  • The donation form
  • Removed a couple unnecessary hidden fields as well

Testing Instructions

  • Make sure GiveWP develop branch is up to date
  • In next-gen run npm run dev
  • Create a next-gen form with a company field
  • Donate using that form and fill in company field
  • Make sure that field is recorded within a donation record in the back-end

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein requested a review from kjohnson August 4, 2022 15:46
@jonwaldstein jonwaldstein marked this pull request as ready for review August 4, 2022 15:46
@jonwaldstein
Copy link
Contributor Author

@kjohnson this is ready for review.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

A build of this branch is available at https://impress-org.github.io/givewp-next-gen/feature/company-field-persistance

Copy link
Contributor

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I love small change sets 😎

@kjohnson kjohnson merged commit 13c3006 into develop Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop

@kjohnson kjohnson deleted the feature/company-field-persistance branch October 25, 2022 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants