This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/feature/template-registration |
…press-org/givewp-next-gen into feature/template-registration
…ClassicForm registration for example
@kjohnson this is ready for review. |
kjohnson
reviewed
Jul 15, 2022
src/NextGen/Framework/FormTemplates/Registrars/FormTemplateRegistrar.php
Show resolved
Hide resolved
src/NextGen/Framework/FormTemplates/Registrars/FormTemplateRegistrar.php
Show resolved
Hide resolved
src/NextGen/Framework/FormTemplates/Registrars/FormTemplateRegistrar.php
Outdated
Show resolved
Hide resolved
kjohnson
reviewed
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonwaldstein added my review - mostly questions and additional commentary. Otherwise, not opposed to this getting merged soon, so I submitted the review as a "Comment" as opposed to "Request Changes".
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently introduced the initial template api as it relates to customizing the front-end. This PR accompanies that by adding a template registration system so new Templates can get registered and pull in their front-end assets.
One of the goals for Templates, is keeping it as simple as possible. If someone wants to create a template that just pulls in some CSS we want them to get up and running easily. Here is a birds eye view of a template simplicity using the (work-in-progress) classic template as an example:
Affects
The new "classic form" was created as the new default for next gen forms. Viewing the form should reflect some basic CSS to show the template is active. Note - this PR is not intended to have a complete version of the Classic Template - just using it for a tangible example until we're ready to build it out.
Also added phpunit here out of necessity.
Visuals
Testing Instructions
View a NextGen form and see some basic css applied. This is the start of what will soon be the Classic Template.
Pre-review Checklist
@unreleased
tags included in DocBlocks