-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/refactor/update-builder-header-31 |
Hey @kjohnson nice job here - please see my video review here: https://www.loom.com/share/18f0a0865484402f9420035b55517c62 Highlights:
cc @jdghinson for items 2 and 3 above. |
Per the call today, I'll update the Publish button to reflect the change to a "primary" button style. |
…s-org/givewp-next-gen into refactor/update-builder-header-31
toggleSecondarySidebar={toggleSecondarySidebar} | ||
showSidebar={showSidebar} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonwaldstein This will probably need to be refactored to a context hook for builder state. I'm looking into that for a later change.Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i'm thinking there will be an application provider for managing this kind of stuff, what you have is fine for now though.
@jonwaldstein flex-basis looks cool - hadn't seen that before. |
…r. organize folder structure a little more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjohnson I made a few updates here:
- Header css updates to make the 3 parts more consistent widths.
- Separated the Header component into presentational and container components. I like to do this as much as possible to isolate components that can truly be pure components, where others are functional.
- Some folder structure updates, moved some things out of the "components" directory, created a "common" directory, and a few root entry points so we can get components & common things easier.
We're getting to a point where the application is growing and it's going to be really important to keep things organized the best we can. Speaking from experience, these react apps can take a shape of their own if we're not careful 😁.
Otherwise, great job!
A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop |
Resolves #31
Description
This PR updates the Form Builder Header Components to reflect the updated design (at least for the components with corresponding features that have been built out).
NOTE: There are some refactoring that this will still need at some point, most notably cleaning up the relationship between icons and buttons, reusable styling, etc. This is focused on getting the components ready for polish.
Visuals
develop
refactor/update-builder-header-31
Pre-review Checklist
Relevant@unreleased
tags included in DocBlocksIncludes unit tests