Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Refactor: update gateways to support $gatewayData introduced in GiveWP 2.22.0 #26

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jul 6, 2022

Description

In GiveWP 2.22.0 we introduced a new $gatewayData parameter in the gateway api that allows gateways to access their custom data easier. This PR updates our gateway form processing to use that param.

Affects

  • Test & NextGenStripe gateways to access their data from $gatewayData param

Visuals

N/A

Testing Instructions

  • Pull branch, run build, and make a donation. Should work the same.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit and/or end-to-end tests
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title refactor: update api to support additional param refactor: update api to support additional param from GiveWP 2.22.0 Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

A build of this branch is available at https://impress-org.github.io/givewp-next-gen/refactor/reflect-core-api-updates

@jonwaldstein jonwaldstein changed the title refactor: update api to support additional param from GiveWP 2.22.0 Refactor: update gateways to support $gatewayData introduced in GiveWP 2.22.0 Sep 9, 2022
@jonwaldstein jonwaldstein marked this pull request as ready for review September 9, 2022 15:03
@jonwaldstein
Copy link
Contributor Author

@kjohnson quick one, ready for review.

Copy link
Contributor

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jonwaldstein jonwaldstein merged commit 3db887e into develop Sep 16, 2022
@jonwaldstein jonwaldstein deleted the refactor/reflect-core-api-updates branch September 16, 2022 18:53
@github-actions
Copy link

A build of this branch is available at https://impress-org.github.io/givewp-next-gen/develop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants