Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Refactor: Email Notification design updates #249

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Refactor: Email Notification design updates #249

merged 4 commits into from
Aug 11, 2023

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Aug 10, 2023 •
edited
Loading

Description

Includes several changes to the Email Notification section of the form builder.

  • last two most right columns are aligned at the top.
  • 'Preview email' column Second row includes a new header for 'Send a test email'
  • 'Preview email' column has updated help messages.
  • Copy tag no longer overlaps description
  • Reduced space between 'Notification' and 'Description'

Affects

Visuals

Previous:
Screen Shot 2023-08-10 at 11 00 40 AM
Updated:
Screen Shot 2023-08-10 at 11 16 14 AM

Testing Instructions

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

kjohnson
kjohnson approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kjohnson kjohnson merged commit aea604f into develop Aug 11, 2023
@kjohnson kjohnson deleted the refactor/email-notification-styles branch August 11, 2023 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kjohnson kjohnson kjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHungDinh @kjohnson