-
Notifications
You must be signed in to change notification settings - Fork 1
Feature: add "default level" option to the Donation amount and levels block #217
Conversation
src/FormBuilder/resources/js/form-builder/src/blocks/fields/amount/inspector/index.tsx
Outdated
Show resolved
Hide resolved
src/DonationForms/Actions/ConvertDonationAmountBlockToFieldsApi.php
Outdated
Show resolved
Hide resolved
src/FormBuilder/resources/js/form-builder/src/blocks/fields/amount/settings.tsx
Show resolved
Hide resolved
src/FormBuilder/resources/js/form-builder/src/blocks/fields/amount/inspector/index.tsx
Outdated
Show resolved
Hide resolved
The biggest thing I'm wondering here, is if something like this would be a better UI for defining the amounts and selecting a default, than adding another dropdown. ![]() cc: @jdghinson |
@JasonTheAdams What's the name of this component? |
@JasonTheAdams The chosen option would have been effective if the default amount is visible in the form builder. However, with the radio in FFM, you can easily select it and see it correctly in the form builder. If we can make it visible like the picture below then we can go with the direction you suggested. |
@jonwaldstein Thanks for the review. I removed the selector, now we're using "Radio" settings on the side of each level to set the default one. I updated the PR description (and screenshots) with the new changes. Let me know if there is anything more. |
src/FormBuilder/resources/js/form-builder/src/blocks/fields/amount/inspector/index.tsx
Outdated
Show resolved
Hide resolved
src/FormBuilder/resources/js/form-builder/src/blocks/fields/amount/inspector/index.tsx
Outdated
Show resolved
Hide resolved
@jonwaldstein Thanks for the review, I implemented the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it, @glaubersilva! What an improvement!
Description
This PR adds a new "Default Level" property as a "Radio" setting on the side of each level input. Now is also possible to reorder the levels using the mouse to drag the items.
Affects
The Donation amount and levels block
Visuals
Testing Instructions
Pre-review Checklist
@unreleased
tags included in DocBlocks