Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: add showHeader setting #184

Merged
merged 3 commits into from
May 23, 2023
Merged

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented May 16, 2023

Description

This adds a simple showHeader settings to the form builder that makes it possible to show or hide the entire header above the form - or in multi-step, the first static step.

Affects

The form builder and donation form.

Visuals

2023-05-22 11 28 43

Screenshot 2023-05-22 at 11 29 50 AM Screenshot 2023-05-22 at 11 30 00 AM

Testing Instructions

  • pull branch and run npm run dev
  • open a next gen form and use the showHeader settings

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Feature: add showHeader setting Feature: add showHeader setting May 16, 2023
@jonwaldstein jonwaldstein marked this pull request as ready for review May 16, 2023 17:25
@jonwaldstein jonwaldstein requested a review from kjohnson May 16, 2023 17:25
@jonwaldstein
Copy link
Contributor Author

@kjohnson this is ready for review.

Copy link
Contributor

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the heading, description, and related toggles be show conditionally based on the value of showHeader?

@JasonTheAdams
Copy link
Contributor

I was thinking the same thing, @kjohnson. Perhaps there should be a "Header" group with the show/hide at the top, which toggles the visibility of the other settings?

@jonwaldstein
Copy link
Contributor Author

@kjohnson this PR has been updated with change to display settings conditionally 0e63ce9

@jonwaldstein jonwaldstein requested a review from kjohnson May 22, 2023 15:32
@jonwaldstein jonwaldstein merged commit 7af01b8 into develop May 23, 2023
@jonwaldstein jonwaldstein deleted the feature/show-header-settings branch May 23, 2023 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants