Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: Add Welcome Banner #142

Merged
merged 18 commits into from
Mar 23, 2023
Merged

Feature: Add Welcome Banner #142

merged 18 commits into from
Mar 23, 2023

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Mar 15, 2023

Depends on https://github.com/impress-org/givewp-gateway-server/pull/20

Description

This PR introduces the Welcome Banner component for the NextGen feature plugin.

Visuals

Welcome Banner (screenshot)
image
Dismiss Action/Animation
Peek 2023-03-16 15-39
Newsletter Subscribe Action/Animation
Peek 2023-03-21 16-15
Responsive Design
Peek 2023-03-16 15-38

Testing Instructions

  • Dismiss the Welcome Banner using the "X"/Close at the top right.
  • Reset the Welcome Banner by deleting the givewp_next_gen_welcome_banner_dismissed option.

Copy link

@jdghinson jdghinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the spacing between the "Next steps" and "Join the Journey", it's 12px in the design and also look at the spacing between these titles ("Join the journey" and "Create your new donation form") and their respective descriptions, it's also 12px in the design. The image looks like the spacing is more than that.

@kjohnson
Copy link
Contributor Author

@jdghinson I updated the spacing around the headings, which had default margins added by the browser that I updated.

@kjohnson kjohnson requested a review from jdghinson March 16, 2023 19:48
@kjohnson kjohnson marked this pull request as ready for review March 16, 2023 19:50
@JasonTheAdams
Copy link
Contributor

Let's hold on merging this until I get the design system PR in place and can use that.

@kjohnson
Copy link
Contributor Author

@jonwaldstein this is ready for review. The design system has been incorporated and the success styles have been updated.

@jonwaldstein
Copy link
Contributor

@kjohnson what was decided about the "Design Mode" and "Custom Fields" images? Looks like they are still placeholders.

@kjohnson
Copy link
Contributor Author

kjohnson commented Mar 22, 2023

@jonwaldstein I updated the screenshots.

image

@jonwaldstein
Copy link
Contributor

@kjohnson thanks, 2 things that don't necessarily have to hold this up:

  1. The "Design Mode" screenshot is an outdated form design.
  2. When clicking the dismiss button it took a few seconds for me until it was removed. I don't think we necessarily need to wait for the server to respond to hide the message.

@kjohnson
Copy link
Contributor Author

@jonwaldstein I updated the dismiss action to remove the banner async. As for the images, I'd say lets make a note for @jdghinson and move ahead with getting this PR merged.

@jonwaldstein
Copy link
Contributor

@kjohnson sounds good, thanks!

@kjohnson kjohnson merged commit 915a855 into develop Mar 23, 2023
@kjohnson kjohnson deleted the feature/welcome-banner branch March 31, 2023 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants