-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the spacing between the "Next steps" and "Join the Journey", it's 12px in the design and also look at the spacing between these titles ("Join the journey" and "Create your new donation form") and their respective descriptions, it's also 12px in the design. The image looks like the spacing is more than that.
@jdghinson I updated the spacing around the headings, which had default margins added by the browser that I updated. |
Let's hold on merging this until I get the design system PR in place and can use that. |
@jonwaldstein this is ready for review. The design system has been incorporated and the success styles have been updated. |
@kjohnson what was decided about the "Design Mode" and "Custom Fields" images? Looks like they are still placeholders. |
@jonwaldstein I updated the screenshots. |
@kjohnson thanks, 2 things that don't necessarily have to hold this up:
|
@jonwaldstein I updated the dismiss action to remove the banner async. As for the images, I'd say lets make a note for @jdghinson and move ahead with getting this PR merged. |
@kjohnson sounds good, thanks! |
Depends on https://github.com/impress-org/givewp-gateway-server/pull/20
Description
This PR introduces the Welcome Banner component for the NextGen feature plugin.
Visuals
Testing Instructions
givewp_next_gen_welcome_banner_dismissed
option.