This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
Refactor: Update feedback styles #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwaldstein
commented
Feb 23, 2023
| return ( | ||
| <svg {...props} width="14" height="14" viewBox="0 0 14 14" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <path d="M11.3327 11.4993H2.66602L0.666016 13.4993V2.16602C0.666016 1.06602 1.56602 0.166016 2.66602 0.166016H11.3327C12.4327 0.166016 13.3327 1.06602 13.3327 2.16602V9.49935C13.3327 10.5993 12.4327 11.4993 11.3327 11.4993Z" fill="white"/> | ||
| <svg |
There was a problem hiding this comment.
I tried to import this as an svg file and assign to an img src but it kept making a relative url as the src instead of an inline data src. This works fine in the next gen app but not here. Must be a webpack config thing since we're using laravel mix here. Should figure that out at some point for the future when using images / local icons.
|
@kjohnson this is ready for review. |
kjohnson
approved these changes
Feb 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to the feedback button include
Affects
Visuals
Testing Instructions
npm run buildPre-review Checklist
@unreleasedtags included in DocBlocks