Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: add form design base styles #132

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Feb 21, 2023

Description

This loads a base css file before other form designs for an easier starting place. By utilizing pico.css & css @layers we can scaffold a classless stylesheet that form designs can easily customize with their own css.

The way we are using pico.css is by pulling in their individual source files. This gives us the flexibility of only importing what we want.

Affects

  • The developer form design uses the base styles now - so all if its own styles have been removed.
  • Tweaks to the classic form design & removing styles that are now apart of the baseline.
  • Removes the WP global styles from our iframe views. We can revisit this when discussing fse/theme.json compatability.

Visuals

Screenshot 2023-02-22 at 12 35 02 PM

Testing Instructions

  • Pull branch and npm install && npm run build
  • Switch between classic and developer form designs

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein marked this pull request as ready for review February 22, 2023 17:43
@jonwaldstein
Copy link
Contributor Author

@kjohnson @JasonTheAdams this is ready for review.

Copy link
Contributor

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! A class-less base styling will be a better developer experience when doing a custom design.

@jonwaldstein jonwaldstein merged commit 8f996cc into develop Feb 27, 2023
@jonwaldstein jonwaldstein deleted the feature/base-form-design-styles branch February 27, 2023 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants