Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: Add receipt settings to the form builder #117

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

kjohnson
Copy link
Contributor

@kjohnson kjohnson commented Jan 18, 2023

Description

This PR adds the Receipt Heading and Receipt Description settings to the Form Builder.

Visuals

image

@kjohnson kjohnson marked this pull request as ready for review January 18, 2023 20:19
@kjohnson kjohnson requested a review from jonwaldstein January 18, 2023 20:19
@jonwaldstein
Copy link
Contributor

@kjohnson just a heads up, I realized we were setting default form settings in a few different locations and they were overwriting each other resulting in some empty defaults. I scaled everything back to coming from the FormSettings DTO itself. Eventually we should come up with a better way of handling that 31cbc35

Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jonwaldstein jonwaldstein merged commit 9e26aff into develop Jan 18, 2023
@jonwaldstein jonwaldstein deleted the feature/builder-receipt-settings branch January 18, 2023 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants