Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Feature: Implement dynamic receipt settings #116

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

jonwaldstein
Copy link
Contributor

@jonwaldstein jonwaldstein commented Jan 17, 2023

Description

This updates the confirmation receipt page to dynamically display the heading and description using the form builder's receipt settings.

Affects

The donation confirmation receipt view.

Visuals

Screenshot 2023-01-18 at 5 24 07 PM

Testing Instructions

Update the heading/description settings and make a donation to see the values displayed in the receipt.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@jonwaldstein jonwaldstein changed the title Feature: add template tags api Feature: Implement dynamic receipt settings Jan 18, 2023
@jonwaldstein jonwaldstein marked this pull request as ready for review January 18, 2023 22:27
@jonwaldstein jonwaldstein requested a review from kjohnson January 18, 2023 22:27
@jonwaldstein
Copy link
Contributor Author

jonwaldstein commented Jan 18, 2023

@kjohnson this is ready for review.

Note: I think we should move the "Receipt and Thank You" settings into the Form tab. Reason being, they have no live preview at the moment - like the rest of the design settings - so it feels confusing in practice to be in the Design tab.

Copy link
Contributor

@kjohnson kjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kjohnson kjohnson merged commit c75007f into develop Jan 19, 2023
@jonwaldstein jonwaldstein deleted the feature/template-tags-api branch January 19, 2023 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants