This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
Fix: Store backwards compatible form meta #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kjohnson can you please write unit tests for these? Will be really helpful to see the assertions for what we're expecting to preserve from our new donation form creation. |
|
@jonwaldstein I updated the tests for this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1203495935004514/1203495935004522/f
Description
This PR stores backwards compatible form meta for:
multi) 1,21 This will be updated to support the Set Donation price option when that is added to the form builder.
2 The meta key is temporarily hard-coded and should be replaced after impress-org/givewp#6614 is merged.
Visuals
Testing Instructions