-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve extended TypeScript configuration files #2240
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2240 +/- ##
==========================================
- Coverage 95.23% 94.63% -0.60%
==========================================
Files 65 65
Lines 2686 2686
Branches 888 888
==========================================
- Hits 2558 2542 -16
- Misses 128 144 +16
Continue to review full report at Codecov.
|
96de64b
to
a316041
Compare
f3c1c4c
to
70c0510
Compare
Thanks for the feedback @ljharb. Let me know if any other changes are needed and I can make them tomorrow :) |
e08bf2a
to
9a744f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Looks like this PR may have broken the WSL windows builds. |
The errors I'm seeing on Appveyor are:
Which seems like it could be something else? Windows 11 has kind of been released in the last day or so, could be related? |
oh hm - "error in certificate verification" might mean it's related to the LetsEncrypt CA expiration last week? |
Thanks for the updates @ljharb! |
Seems like appveyor fixed itself. |
Thank you! |
This PR resolves #1908.
In a comparison I ran locally, the output is:
For reference, the shared config has: