Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] newline-after-import: respect decorator annotations #1985

Merged
merged 1 commit into from
May 12, 2021
Merged

[Fix] newline-after-import: respect decorator annotations #1985

merged 1 commit into from
May 12, 2021

Conversation

lilling
Copy link
Contributor

@lilling lilling commented Feb 2, 2021 •
edited
Loading

hey! found the bug. here in my pr enjoy!

how do I link it with #1784 ?

@lilling
Copy link
Contributor Author

lilling commented Feb 2, 2021

this is my fr pr ever to Github
I'll be glad if you guys can help me understand the failing checks

ljharb
ljharb requested changes Feb 2, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats! To link the PR with an issue, edit either the OP of the PR, and/or the commit message, to contain a phrase like Fixes #1784 (or "closes", "resolves", etc - there's a bunch).

The appveyor WSL failures can be ignored, they always fail.

I'm not sure why the webpack resolver tests are failing; I'll look into it.

tests/src/rules/newline-after-import.js Outdated Show resolved Hide resolved
tests/src/rules/newline-after-import.js Outdated Show resolved Hide resolved
@lilling lilling requested a review from ljharb February 2, 2021 20:52
@ljharb
Copy link
Member

ljharb commented Feb 2, 2021

Looks like today's npm 7 promotion caused some tests to break on master. I'll fix those, and then rebase your PR on top of it.

@coveralls
Copy link

coveralls commented Feb 3, 2021 •
edited
Loading

Coverage Status

Coverage increased (+13.0%) to 84.028% when pulling 359b6e5 on lilling:fix-1784 into 1c10e79 on benmosher:master.

@lilling
Copy link
Contributor Author

lilling commented Feb 7, 2021

@ljharb do you have any updates?

@ljharb
Copy link
Member

ljharb commented Feb 7, 2021

@lilling no, I’m afraid not :-/ it’s being tracked in #1986, and you don’t have to do anything else - once that’s done, I’ll rebase this, and we can get it in :-)

@ljharb ljharb changed the title Fix 1784 [Fix] newline-after-import: respect decorator annotations Feb 28, 2021
@ljharb
Copy link
Member

ljharb commented Mar 1, 2021

@lilling i've fixed master, so it looks like these are real failures. Please mark this PR as ready for review once you've figured them out :-)

@ljharb ljharb marked this pull request as draft March 1, 2021 17:09
@ljharb
Copy link
Member

ljharb commented Mar 1, 2021

I'm seeing a few flaky failures in other PRs, so it might not actually be your branch. Stand by :-)

@lilling
Copy link
Contributor Author

lilling commented May 12, 2021

@ljharb Any updates?

@ljharb ljharb marked this pull request as ready for review May 12, 2021 17:31
@ljharb ljharb merged commit 359b6e5 into import-js:master May 12, 2021
@minwe
Copy link

minwe commented May 14, 2021 •
edited
Loading

ESLint got error on [email protected]

ESLint: 7.26.0

TypeError: Cannot read property 'type' of null
Occurred while linting /src/components/Range/index.ts:3
    at isExportNameClass (/node_modules/[email protected]@eslint-plugin-import/lib/rules/newline-after-import.js:54:69)

@ljharb
Copy link
Member

ljharb commented May 14, 2021

@minwe in general, please file new issues for things like that. This one already is filed as #2056 and #2063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilling @ljharb @coveralls @minwe