Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] dynamic-import-chunkname/TypeScript: support @typescript-eslint/parser #1833

Merged
merged 1 commit into from
Jun 21, 2020
Merged

[Fix] dynamic-import-chunkname/TypeScript: support @typescript-eslint/parser #1833

merged 1 commit into from
Jun 21, 2020

Conversation

noelebrun
Copy link
Contributor

This PR add supports for the @typescript-eslint/parser parser to the dynamic-import-chunkname rule. This parser use newer ES Tree spec ImportExpression from dynamic imports instead of CallExpressions.

This might fix #1771 but I haven't tried bumping babel-eslint to try it.

cc @ljharb

@coveralls
Copy link

coveralls commented Jun 20, 2020

Coverage Status

Coverage increased (+0.0009%) to 97.896% when pulling 4d6c539 on noelebrun:support-typescript-parser-for-dynamic-import-chunkname into 2962628 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 97.681% when pulling bac9acb on noelebrun:support-typescript-parser-for-dynamic-import-chunkname into 2962628 on benmosher:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test run for v2 of the typescript eslint parser, which seems to be currently failing.

I'll update the PR to pass those tests as well, so we don't accidentally make this a breaking change.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out it was just the test expectation; everything still works. LGTM once tests pass, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

dynamic-import-chunkname doesn't work with latest babel-eslint
3 participants