New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no internal modules with exports #1691

Merged

ljharb merged 1 commit into import-js:master from adjerbetian:update-no-internal-modules-with-exports

Jun 2, 2020

adjerbetian commented Mar 22, 2020 •

edited

Loading

Resolves #1481

About the breaking change

In the ticket it was suggested to add an option for this behavior. Do you still want this rule behind an option? This behavior with the export feels so natural to me that I would feel strange if it wasn't the default behavior.

Changelog

I update the documentation, but I didn't know how to update the changelog. I wouldn't be against some guidance or help here 😊.

Step down rule

I hesitated to clean the code in /src/rules/no-internal-modules.js to use the step down rule, but I don't want to impose my tastes on this. Do you want me to do it?


          [Fix] no-internal-modules: also check export from syntax

9dfef28

Fixes #1481.

coveralls commented Mar 22, 2020 •

edited

Loading

Coverage increased (+0.002%) to 97.739% when pulling 9dfef28 on adjerbetian:update-no-internal-modules-with-exports into 6dd28ea on benmosher:master.

coveralls commented Mar 22, 2020

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

4 similar comments

coveralls commented Mar 22, 2020

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

coveralls commented Mar 22, 2020

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

coveralls commented Mar 22, 2020

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

coveralls commented Mar 22, 2020

Coverage decreased (-0.1%) to 97.667% when pulling 9371aa7 on adjerbetian:update-no-internal-modules-with-exports into efb5f07 on benmosher:master.

This comment has been minimized.

Sign in to view

Author

adjerbetian commented Apr 5, 2020

@ljharb Can you give me your opinion on this?

Member

ljharb commented Jun 2, 2020

I agree; this feels like a bugfix.

ljharb approved these changes

View reviewed changes

ljharb merged commit 9dfef28 into import-js:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet