Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New group types #1240

Closed
wants to merge 4 commits into from
Closed

New group types #1240

wants to merge 4 commits into from

Conversation

evless
Copy link

@evless evless commented Nov 23, 2018

Hello! I stumbled upon an old PR - #1076, but tests fell there. I forked it and repaired this moment.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.382% when pulling 28ba389 on evless:new-group-types into 798eed7 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.382% when pulling 28ba389 on evless:new-group-types into 798eed7 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.382% when pulling 28ba389 on evless:new-group-types into 798eed7 on benmosher:master.

@ljharb
Copy link
Member

ljharb commented Nov 24, 2018

In the future, please post a link to your new commits on the original PR, and a maintainer will pull them in - now I have to keep 2 PRs in sync.

@jeffshaver
Copy link
Contributor

@ljharb @evless Any update on this? Would be nice to get this in. With TS choosing to move away from tslint, having this would allow us to make a group for Typescript path aliases which would be really nice.

@evless
Copy link
Author

evless commented Feb 19, 2019

@jeffshaver I don't know. I'm also waiting for this PR to be merged. Now I use changes from my fork. :(

@ljharb
Copy link
Member

ljharb commented Feb 20, 2019

See #1076; this PR will only be merged as part of that one, since it's a copy of it.

@import-js import-js locked as resolved and limited conversation to collaborators Feb 20, 2019
@benmosher
Copy link
Member

FWIW I am working on having the resolver API float group types, but I'ma close this since it's locked already anyway

@benmosher benmosher closed this Jun 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants