add special cases for csv and tsv formatting [IMPLY-34859]

[mcbrewster]

We want null columns to be represented by a space and empty strings to be represented by "". To support this we need to add in special logic in both the TSV and CSV finalizers to return the right values.

[jgoz]

We want null columns to be represented by a space and empty strings to be represented by "".

Do we want this in both CSV and TSV? Because it looks like empty string handling only applies to TSV

[mcbrewster]

We want null columns to be represented by a space and empty strings to be represented by "".

Do we want this in both CSV and TSV? Because it looks like empty string handling only applies to TSV

It has a check for v !== "", if it is an empty string then it will use the string escaping logic that csv's use and that will return '""'. I was just trying to reuse what was there but I can make it more explicit.

[jgoz]

Maybe I'm being dense, but I don't see where the empty string will get transformed for CSVs. I see where quotes get escaped, but empty string won't contain quotes...

[mcbrewster]

Maybe I'm being dense, but I don't see where the empty string will get transformed for CSVs. I see where quotes get escaped, but empty string won't contain quotes...

if it's if **(v !== ''** && v.indexOf('"') === -1 && v.indexOf(',') === -1) return v;
therefore empty string will drop down and return:
"${v.replace(/"/g, '""')}"
you can see it is a template string with quotes and then the inside gets escaped. I am just going to change it though to make it more readable.

[jgoz]

🍣 Thank you. I was definitely being dense and missed the quotes that were wrapping the fallthrough case. But I like the explicit version where TSV and CSV are more similar to each other.