-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor DX/UX improvements #323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-mader
added
the
Enhancement
New feature or improvement to an existing feature
label
Aug 7, 2024
daniel-mader
force-pushed
the
refactor/dx-improvements
branch
4 times, most recently
from
August 7, 2024 13:35
d4eba37
to
c58d5c5
Compare
daniel-mader
force-pushed
the
refactor/dx-improvements
branch
from
August 7, 2024 13:45
c58d5c5
to
a63d5dd
Compare
daniel-mader
changed the title
chore: minor DX improvements
chore: minor DX/UX improvements
Aug 7, 2024
maiertech
reviewed
Aug 7, 2024
maiertech
previously requested changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to test onboarding workflow. Page redirection bug: from /welcome/terms
to /welcome
. Bug survives app restart.
Might be related to #246.
nanderstabel
reviewed
Aug 7, 2024
identity-wallet/src/state/dev_mode/reducers/ferris_static_profile.rs
Outdated
Show resolved
Hide resolved
nanderstabel
requested changes
Aug 7, 2024
daniel-mader
force-pushed
the
refactor/dx-improvements
branch
from
August 7, 2024 23:03
106edd7
to
429d5e9
Compare
daniel-mader
force-pushed
the
refactor/dx-improvements
branch
from
August 8, 2024 12:46
35df550
to
2f19df3
Compare
6 tasks
Oran-Dan
previously approved these changes
Aug 9, 2024
Oran-Dan
approved these changes
Aug 9, 2024
nanderstabel
approved these changes
Aug 9, 2024
daniel-mader
dismissed
maiertech’s stale review
August 9, 2024 09:40
Onboarding could successfully passed in a mobile build. Issue seems to occur in local development only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Includes some minor DX improvements:
date_issued
from a Ferris test credential was changed to improve the sorting experience@iconify
icon sets are removed from the devDependencies/welcome/password/completed
was renamed to/welcome/completed
for consistencyapply.sh
allows to copy all files ingen-static
==>gen
to the expected location.This is useful when regenerating the (untracked) mobile apps.
Links to any relevant issues
n/a
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.