Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor DX/UX improvements #323

Merged
merged 11 commits into from
Aug 9, 2024
Merged

chore: minor DX/UX improvements #323

merged 11 commits into from
Aug 9, 2024

Conversation

daniel-mader
Copy link
Collaborator

@daniel-mader daniel-mader commented Aug 7, 2024

Description of change

Includes some minor DX improvements:

  • Developer toolbar icon for the debug log was changed (due to inconsistent stroke width when using a different icon set)
  • The date_issued from a Ferris test credential was changed to improve the sorting experience
  • Unused @iconify icon sets are removed from the devDependencies
  • Route /welcome/password/completed was renamed to /welcome/completed for consistency
  • Updated some comments
  • Mock scan page has disclaimer
  • New mock scan added: "Receive credential offer"
  • A new script named apply.sh allows to copy all files in gen-static ==> gen to the expected location.
    This is useful when regenerating the (untracked) mobile apps.

Links to any relevant issues

n/a

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader self-assigned this Aug 7, 2024
@daniel-mader daniel-mader added the Enhancement New feature or improvement to an existing feature label Aug 7, 2024
@daniel-mader daniel-mader force-pushed the refactor/dx-improvements branch 4 times, most recently from d4eba37 to c58d5c5 Compare August 7, 2024 13:35
@daniel-mader daniel-mader force-pushed the refactor/dx-improvements branch from c58d5c5 to a63d5dd Compare August 7, 2024 13:45
@daniel-mader daniel-mader changed the title chore: minor DX improvements chore: minor DX/UX improvements Aug 7, 2024
Copy link
Member

@maiertech maiertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test onboarding workflow. Page redirection bug: from /welcome/terms to /welcome. Bug survives app restart.

Might be related to #246.

@daniel-mader daniel-mader force-pushed the refactor/dx-improvements branch from 106edd7 to 429d5e9 Compare August 7, 2024 23:03
@daniel-mader daniel-mader force-pushed the refactor/dx-improvements branch from 35df550 to 2f19df3 Compare August 8, 2024 12:46
Oran-Dan
Oran-Dan previously approved these changes Aug 9, 2024
@daniel-mader daniel-mader dismissed maiertech’s stale review August 9, 2024 09:40

Onboarding could successfully passed in a mobile build. Issue seems to occur in local development only.

@daniel-mader daniel-mader merged commit 9032da2 into dev Aug 9, 2024
3 checks passed
@daniel-mader daniel-mader deleted the refactor/dx-improvements branch August 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants