Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch credential logo URI from logo.uri #321

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented Aug 6, 2024

Description of change

#301 already fixed that the Credential Issuers logo is fetched from logo.uri (instead of logo.url).

This PR does the same for the individual Credential logo's.

Before:
image

After:
image

Links to any relevant issues

How the change has been tested

Tested manually against https://staging.client.ngdil.com/demo

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel added the Bug Something isn't working label Aug 6, 2024
@nanderstabel nanderstabel self-assigned this Aug 6, 2024
@nanderstabel nanderstabel merged commit e05cb3e into dev Aug 7, 2024
3 checks passed
@nanderstabel nanderstabel deleted the fix/credential-logo-uri branch August 7, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants