Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various UI adjustments & fixes (badge details) #115

Merged
merged 25 commits into from
Feb 19, 2024
Merged

fix: various UI adjustments & fixes (badge details) #115

merged 25 commits into from
Feb 19, 2024

Conversation

daniel-mader
Copy link
Collaborator

@daniel-mader daniel-mader commented Feb 14, 2024 •
edited
Loading

Description of change

Solved some UI bugs (mainly on the "Badge details" page).

Links to any relevant issues

n/a

How the change has been tested

Manual inspection

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader changed the title fix: various UI fixes (Badge details) fix: various UI fixes (badge details) Feb 14, 2024
@daniel-mader daniel-mader changed the title fix: various UI fixes (badge details) fix: various UI adjustments & fixes (badge details) Feb 15, 2024
@daniel-mader daniel-mader marked this pull request as ready for review February 15, 2024 14:47
Norlock
Norlock suggested changes Feb 16, 2024
View reviewed changes
identity-wallet/src/state/reducers/dev_mode.rs Outdated Show resolved Hide resolved
unime/src/lib/components/atoms/Image.svelte Show resolved Hide resolved
unime/src/routes/(app)/scan/[email protected] Outdated Show resolved Hide resolved
unime/src/routes/badges/[id]/+page.svelte Outdated Show resolved Hide resolved
unime/src/routes/badges/[id]/+page.svelte Show resolved Hide resolved
unime/src/routes/badges/[id]/+page.svelte Outdated Show resolved Hide resolved
unime/src/routes/badges/[id]/+page.svelte Outdated Show resolved Hide resolved
@nanderstabel nanderstabel self-requested a review February 16, 2024 17:29
@nanderstabel nanderstabel self-requested a review February 19, 2024 09:50
nanderstabel
nanderstabel previously approved these changes Feb 19, 2024
View reviewed changes
@nanderstabel nanderstabel self-requested a review February 19, 2024 13:56
Norlock
Norlock approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Norlock Norlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-mader daniel-mader merged commit 1254d10 into dev Feb 19, 2024
1 check passed
@daniel-mader daniel-mader deleted the fix/various-ui-fixes branch February 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoulaAndrikopoulos SoulaAndrikopoulos SoulaAndrikopoulos left review comments

@Norlock Norlock Norlock approved these changes

@nanderstabel nanderstabel nanderstabel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-mader @Norlock @SoulaAndrikopoulos @nanderstabel