Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: omit default https port, disallow IP addresses #26

Merged
merged 1 commit into from
Aug 6, 2024
Merged

chore: omit default https port, disallow IP addresses #26

merged 1 commit into from
Aug 6, 2024

Conversation

daniel-mader
Copy link
Contributor

@daniel-mader daniel-mader commented Aug 5, 2024 •
edited
Loading

Description of change

  • default https port (443) is omitted when constructing the DID method-specific identifier (host) from the given origin
  • IP addresses are disallowed (as defined in the spec)

Links to any relevant issues

How the change has been tested

All tests pass.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader added Chore Tedious, typically non-functional change Enhancement New feature or improvement to an existing feature labels Aug 5, 2024
@daniel-mader daniel-mader self-assigned this Aug 5, 2024
@daniel-mader daniel-mader merged commit 7d39e00 into dev Aug 6, 2024
1 check passed
@daniel-mader daniel-mader deleted the chore/omit-default-port branch August 6, 2024 22:26
nanderstabel pushed a commit that referenced this pull request Aug 8, 2024
@daniel-mader @nanderstabel
chore: omit default https port, disallow IP addresses (#26)
18106ac
nanderstabel pushed a commit that referenced this pull request Aug 8, 2024
@daniel-mader @nanderstabel
chore: omit default https port, disallow IP addresses (#26)
af62416
nanderstabel pushed a commit that referenced this pull request Aug 8, 2024
@daniel-mader @nanderstabel
chore: omit default https port, disallow IP addresses (#26)
7017e2f
nanderstabel pushed a commit that referenced this pull request Aug 8, 2024
@daniel-mader @nanderstabel
chore: omit default https port, disallow IP addresses (#26)
ef31d37
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanderstabel nanderstabel nanderstabel approved these changes

Assignees

@daniel-mader daniel-mader

Labels
Chore Tedious, typically non-functional change Enhancement New feature or improvement to an existing feature released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] did:web generates a did that encodes default ports in the @id.
2 participants
@daniel-mader @nanderstabel