Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple risk factor code from DataTable backend #166

Closed
jamesturner246 opened this issue Jul 18, 2023 · 0 comments · Fixed by #195
Closed

Decouple risk factor code from DataTable backend #166

jamesturner246 opened this issue Jul 18, 2023 · 0 comments · Fixed by #195
Assignees

Comments

@jamesturner246
Copy link
Contributor

jamesturner246 commented Jul 18, 2023

Right now, DataTable initialisation (from CSV files) is very tightly coupled to the risk factors defined in the config JSON files. Adding risk factors tends to break the DataTable if corresponding CSV data columns have not been provided.

We should investigate the parts of the code that prevent this from adding non-data-driven risk factors which are not initialised with data from the DataTable (CSV files), and change it to allow us to choose how risk factors are individually initialised.

We will probably, for example in the new EBM, need to declare risk factors depending on the "Foods" fields in France.NewEBM.json, and initialise/update them with our own method.

In an ideal world, the main config file, e.g. France.Config.json, should not contain risk factor variables (which are duplicated in the dynamic model config JSON anyway).

Edit: after discussion with Israel, it is agreed that the RF definition in France.Config.json is redundant, and can be removed.

@jamesturner246 jamesturner246 converted this from a draft issue Jul 18, 2023
@jamesturner246 jamesturner246 moved this from 📋 Backlog to 🔖 Ready in Health-GPS Jul 24, 2023
@jamesturner246 jamesturner246 self-assigned this Jul 24, 2023
@jamesturner246 jamesturner246 moved this from 🔖 Ready to 🏗 In progress in Health-GPS Jul 29, 2023
@jamesturner246 jamesturner246 moved this from 🏗 In progress to 👀 In review in Health-GPS Aug 2, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Health-GPS Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant