Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitisation of input data #161

Closed
jamesturner246 opened this issue Jul 14, 2023 · 1 comment · Fixed by #200
Closed

Sanitisation of input data #161

jamesturner246 opened this issue Jul 14, 2023 · 1 comment · Fixed by #200
Assignees

Comments

@jamesturner246
Copy link
Contributor

The whole model loading core in model_parser could do with a rethink, to test that both the main config file -- e.g. France.Config.json -- has sensible values and if fully defined. Same for the static and dynamic risk factor configs -- e.g. France.HLM.json and France.NewEBM.json.

Furthermore, we should check that the data is complete over defined ranges. For example, if max age is defined as x, we should ensure that all age dependent data is defined up to at least x.

The code should fail on any missing data, and any missing files -- it often just carries on silently/with a warning message.

@jamesturner246 jamesturner246 converted this from a draft issue Jul 14, 2023
@dalonsoa dalonsoa moved this from 📋 Backlog to 🔖 Ready in Health-GPS Jul 24, 2023
@dalonsoa dalonsoa moved this from 🔖 Ready to 🏗 In progress in Health-GPS Jul 31, 2023
@alexdewar
Copy link
Contributor

Waiting for #166 to be finished before starting on this.

This was referenced Aug 3, 2023
@dalonsoa dalonsoa moved this from 🏗 In progress to 👀 In review in Health-GPS Aug 16, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Health-GPS Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants