Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Error Handling #314

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Web: Error Handling #314

merged 1 commit into from
Apr 18, 2023

Conversation

hugomarquesdev
Copy link
Contributor

@hugomarquesdev hugomarquesdev self-assigned this Apr 6, 2023
@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 1:55pm

@hugomarquesdev hugomarquesdev force-pushed the feature/error-handling branch from 8241fee to 13599e9 Compare April 6, 2023 13:51
@hugomarquesdev hugomarquesdev removed their assignment Apr 6, 2023
@vibern0 vibern0 requested review from Marianavpt and removed request for vibern0 April 6, 2023 14:03
Copy link

@Marianavpt Marianavpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I exactly test this please?

@vibern0
Copy link

vibern0 commented Apr 11, 2023

How can I exactly test this please?

it's actually not easy because metamask will warn you that you don't have funds. Maybe Libera should do the same. Added https://github.com/impactMarket/libera/issues/363
But this should work, looks good.

@vibern0
Copy link

vibern0 commented Apr 11, 2023

@PauloSousapt

@vibern0 vibern0 merged commit b5f254b into main Apr 18, 2023
@vibern0 vibern0 deleted the feature/error-handling branch April 18, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants