Add test to ensure valid JSON schema is available for all domain objects #404
Labels
enhancement
Nice to have, non-functional requirements.
Comments
Merged
Whathecode
added a commit
that referenced
this issue
Oct 26, 2024
This seems to have introduced better evaluation of `allOf` and `oneOf` references. However, it does seem to introduce a bug which causes it not to consider properties in nested schemas more than 1 level deep when evaluating `unevaluatedProperties`: networknt/json-schema-validator#1123 Therefore, this requirement has been removed in schemas where it was causing current validation to fail. Note that not all concrete types are currently evaluated (#404), so there are many other schemas which would also fail if they were to be evaluated.
Whathecode
added a commit
that referenced
this issue
Oct 27, 2024
This seems to have introduced better evaluation of `allOf` and `oneOf` references. However, it does seem to introduce a bug which causes it not to consider properties in nested schemas more than 1 level deep when evaluating `unevaluatedProperties`: networknt/json-schema-validator#1123 Therefore, a hack was introduced to make sure validation succeeds.. Note that not all concrete types are currently evaluated (#404), so there are many other schemas which would also fail if they were to be evaluated, and they would need to apply a similar fix.
Whathecode
added a commit
that referenced
this issue
Oct 27, 2024
This seems to have introduced better evaluation of `allOf` and `oneOf` references. However, it does seem to introduce a bug which causes it not to consider properties in nested schemas more than 1 level deep when evaluating `unevaluatedProperties`: networknt/json-schema-validator#1123 Therefore, a hack was introduced to make sure validation succeeds.. Note that not all concrete types are currently evaluated (#404), so there are many other schemas which would also fail if they were to be evaluated, and they would need to apply a similar fix.
Whathecode
added a commit
that referenced
this issue
Oct 28, 2024
This seems to have introduced better evaluation of `allOf` and `oneOf` references. However, it does seem to introduce a bug which causes it not to consider properties in nested schemas more than 1 level deep when evaluating `unevaluatedProperties`: networknt/json-schema-validator#1123 Therefore, a hack was introduced to make sure validation succeeds.. Note that not all concrete types are currently evaluated (#404), so there are many other schemas which would also fail if they were to be evaluated, and they would need to apply a similar fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, JSON schemas for all request objects are validated in
JsonSchemasTest.But, this does not include tests for all extending domain types.
An instance for all extending types is available in common test sources (
TestInstances). And, a unit test verifies whether an instance is available for each of the domain types. If we could reuse these sources (#23), we could likely set up a test which verifies whether a schema for each is available, and which validates the schema.The text was updated successfully, but these errors were encountered: