Add EDA data type #405
Merged
Add EDA data type #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an upcoming sensor integration which can measure electrodermal activity (also known as GSR), an EDA data type was added. Closes #399
While implementing this, I introduced a development checklist for introducing new data types to CARP Core. It's introduced as part of this PR.
There are already quite a few unit tests to guide developers in doing this correctly. But, I noticed there was no check whether a newly introduced data type is added to
CarpDataTypes. So, I started out by introducing a unit test for this.I also noticed there is no check to verify whether a valid JSON schema is available for the
Datatype. But, introducing a test for this seems less straightforward so I added a new backlog item for this instead: #404Lastly, I noticed some of the existing data types (heart rate and geolocation) were too liberal in the values they accepted. I updated the
Dataclasses and JSON schemas accordingly.