Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX-3575] test: fix mac ui requiring keychain access #408

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Feb 11, 2025

Summary

  • Our SDK needs access to the keychain to retrieve stored tokens. This means that when UI tests are executed, a prompt for the login password appears, which, so far, needs to be entered manually to continue the tests. This PR is to create and use a temporary keychain instead.
  • Avoid printing access and ID tokens in tests, even if they're obfuscated by GitHub.

@nattb8 nattb8 requested a review from a team as a code owner February 11, 2025 02:14
@nattb8 nattb8 merged commit 6e8fb09 into main Feb 11, 2025
20 checks passed
@nattb8 nattb8 deleted the test/mac-keychain branch February 11, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants