Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX-3550] refactor: marketplace query params #390

Merged
merged 5 commits into from
Jan 29, 2025
Merged

[DX-3550] refactor: marketplace query params #390

merged 5 commits into from
Jan 29, 2025

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Jan 28, 2025 •
edited
Loading

Summary

  • Refactored the marketplace link generation functions to utilise structs for query parameters.
  • Alphabetised the on-ramp query parameters dictionary.
  • Added an additional argument extraQueryParams to GenerateOnRampLink so that developers can include more configurations. Developers can refer to the Transak documentation for further configuration fields.

Other things to consider:

  • Sample app is updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Sample game is updated with new SDK changes

@nattb8 nattb8 requested a review from a team as a code owner January 28, 2025 05:49
@nattb8 nattb8 force-pushed the refactor/marketplace-query-params branch from 80d4887 to f06cab4 Compare January 28, 2025 19:51
@nattb8 nattb8 merged commit 1a940b2 into main Jan 29, 2025
18 checks passed
@nattb8 nattb8 deleted the refactor/marketplace-query-params branch January 29, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImmutableJeffrey ImmutableJeffrey ImmutableJeffrey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattb8 @ImmutableJeffrey