Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more flexible access controls for contract deployment #219

Merged
merged 6 commits into from
May 15, 2024

Conversation

ermyas
Copy link
Contributor

@ermyas ermyas commented May 14, 2024

The existing OwnableCreate2Deployer and OwnableCreate3Deployer contracts only allow a single deployer address—the owner—to deploy contracts. There is a need to enhance this so as to allow a set of authorised addresses to deploy contracts. This PR introduces a new contract that forwards deployment requests to the existing Create2 and Create3 deployers while layering role-based access controls to these capabilities. This contract could thus enable more flexible deployment access controls for existing single-owner Create2 and Create3 deployers.
Additional details of this requirement can be found here.

@ermyas ermyas requested review from wcgcyx and Benjimmutable May 14, 2024 02:21
Copy link

openzeppelin-code bot commented May 14, 2024

Enable more flexible access controls for contract deployment

Generated at commit: 6e068688b46e59643abf31b55071d4a3467840c9

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
11
28
42
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@ermyas ermyas marked this pull request as ready for review May 14, 2024 20:32
@ermyas ermyas requested a review from Benjimmutable May 14, 2024 20:32
Copy link

@wcgcyx wcgcyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

@ermyas ermyas merged commit f0d0c44 into main May 15, 2024
6 of 7 checks passed
@Benjimmutable Benjimmutable deleted the feature/deployer/RBAC_contract_deployer branch May 15, 2024 23:17
@ermyas ermyas mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants