Add support for creating threads on ARM #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrtonm
force-pushed
the
am/qemu_tests
branch
20 times, most recently
from
f620a28
to
ff75a18
Compare
fw-immunant
force-pushed
the
am/arm_threads
branch
from
f6d67b9
to
16a84b8
Compare
|
As noted in |
fw-immunant
force-pushed
the
am/arm_threads
branch
from
16a84b8
to
60b74bc
Compare
ayrtonm
force-pushed
the
am/arm_threads
branch
from
60b74bc
to
49cb863
Compare
ayrtonm
force-pushed
the
am/arm_threads
branch
from
6099a1b
to
cad853e
Compare
ayrtonm
force-pushed
the
am/arm_threads
branch
from
cad853e
to
4ddd595
Compare
Making this API arch-independent seems like a more sane approach, but there is another copy of these functions in ia2_get_pkey.h. I assumed that this was to be able to call it without changing into the compartment with libia2.a but it seems like we don't include it anywhere so it may be dead code. I fixed the usage of this API in the tests in a separate commit but we still need to fix it in PartitionAlloc and its shim.
Note: this needs x18 switching in the call gates to pass
This will make it easier to avoid duplicating code when adding the arm implementation.
ayrtonm
force-pushed
the
am/arm_threads
branch
from
4ddd595
to
e6edc4c
Compare
|
ARM is failing because of tls_protected. Given that file-backed mappings don't enforce MTE protections we might not be able to enable the test yet. |
ayrtonm
force-pushed
the
am/arm_threads
branch
from
e6edc4c
to
9e022fb
Compare
|
TODO: strace tls_protected to check if the issue is actually that it's a file-backed mapping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The threads test now builds and should work modulo stack alignment in
ia2_thread_begin. Running the test hits a fault before it gets to create a thread, but I need to review the test handler header ARM impl before relying on tests' error messages.