Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add LocalProvider value updates publisher #30

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Feat: add LocalProvider value updates publisher #30

merged 2 commits into from
Aug 31, 2023

Conversation

NicFontana
Copy link
Contributor

This MR adds LocalProvider flag's value updates notifications by emitting changes through a Combine Publisher.

Particularly:

  • The method func didUpdateValuesForKeys(_ keys: Set<String>?) -> AnyPublisher<Set<String>, Never>? of the FlagsProvider has been refactored to allow the subscribers to receive both the FlagKeyPath and the FlagProtocol involved in the updates.
  • The LocalProvider now returns an actual publisher inside that method, instead of the default nil.

@malcommac malcommac added this to the 2.0.1 milestone Aug 31, 2023
@malcommac malcommac added the enhancement New feature or request label Aug 31, 2023
@malcommac malcommac merged commit 291b183 into immobiliare:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@NicFontana @malcommac