Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): stop slideshow when pressing escape from asset viewer #9929

Merged
merged 2 commits into from
Jun 2, 2024
Merged

fix(web): stop slideshow when pressing escape from asset viewer #9929

merged 2 commits into from
Jun 2, 2024

Conversation

Snowknight26
Copy link
Contributor

@Snowknight26 Snowknight26 commented Jun 1, 2024 •
edited
Loading

Fixes #9904.

@Snowknight26
Copy link
Contributor Author

Not sure there's an effective way to test this. Attempting to render the AssetViewer component requires mocking almost everything under the sun. Would extracting closeViewer into its own file and testing the two code paths (if, else) be overkill?

@Snowknight26 Snowknight26 marked this pull request as ready for review June 1, 2024 21:24
@jrasm91 jrasm91 merged commit 203cbbb into immich-app:main Jun 2, 2024
22 checks passed
@Snowknight26 Snowknight26 deleted the fix/exit-slideshow-with-escape branch June 2, 2024 03:01
@anudeepreddy anudeepreddy mentioned this pull request Jun 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web: Exiting slideshow with escape key closes the asset viewer
3 participants
@Snowknight26 @jrasm91 @danieldietzler