-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): set album description textarea height correctly #9880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests for this functionality?
What kind of tests are you looking for? Unit? Integration/e2e test? I couldn't find any contributing guidelines on tests so I'm not sure what's expected, but will do my best to add what's needed. If it matters, the existing |
There have just been a lot of bugs with the description field not working properly. It should change when you navigate to the next asset and it should resize as well. A unit test would probably be fine. I think there are a few examples of this. |
Admittedly I don't know how to test the resizing functionality (and admittedly, should resizing be tested, or just that the auto-grow function is called?) or navigating.. but I wonder if what's been added is adequate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes #9879.
Changes:
value
is not a valid textarea property