Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Option to assign people to unassigned faces #9773

Merged
merged 14 commits into from
Jun 5, 2024

Conversation

Jan108
Copy link
Contributor

@Jan108 Jan108 commented May 26, 2024

Added the possibility to assign a person to an unassigned face. This includes:

  • Show in the detail panel that there are unassigned faces
  • Show all faces in the person-side-panel, and highlight faces without a person assigned

grafik
grafik

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! This is something I've wanted to add for some time.

web/src/lib/components/asset-viewer/detail-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/asset-viewer/detail-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/asset-viewer/detail-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/faces-page/person-side-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/faces-page/person-side-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/faces-page/person-side-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/faces-page/person-side-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/components/faces-page/person-side-panel.svelte Outdated Show resolved Hide resolved
web/src/lib/utils/people-utils.ts Outdated Show resolved Hide resolved
@Jan108 Jan108 requested a review from danieldietzler as a code owner May 29, 2024 14:42
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 enabled auto-merge (squash) June 5, 2024 07:23
@alextran1502 alextran1502 merged commit b2761b1 into immich-app:main Jun 5, 2024
21 of 22 checks passed
@Jan108 Jan108 deleted the feat/web-faces branch August 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants