Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): search duplicates of the same asset type #9747

Merged
merged 3 commits into from
May 26, 2024

Conversation

mertalev
Copy link
Contributor

Description

Duplicate detection currently treats images and videos as duplicates so long as their previews look similar. This is nonsensical since they're known to be different asset types. This PR filters by asset type to correct this.

Copy link

cloudflare-workers-and-pages bot commented May 25, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: b072ed8
Status: ✅  Deploy successful!
Preview URL: https://7ef41bc2.immich.pages.dev
Branch Preview URL: https://fix-server-duplicate-asset-t.immich.pages.dev

View logs

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 enabled auto-merge (squash) May 26, 2024 21:59
@alextran1502 alextran1502 merged commit e7c8501 into main May 26, 2024
24 checks passed
@alextran1502 alextran1502 deleted the fix/server-duplicate-asset-type branch May 26, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants