refactor(web): ConfirmDialog and dialogController #9716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
3507317
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c341fe87.immich.pages.dev |
| Branch Preview URL: | https://web-feat-dialog-controller.immich.pages.dev |
zackpollard
reviewed
May 24, 2024
web/src/lib/components/photos-page/actions/remove-from-shared-link.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/shared-components/dialog/dialog-wrapper.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/shared-components/full-screen-modal.svelte
Outdated
Show resolved
Hide resolved
|
Love the overall changes, just some small comments :) |
jrasm91
reviewed
May 24, 2024
web/src/lib/components/shared-components/full-screen-modal.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/shared-components/dialog/dialog-wrapper.svelte
Outdated
Show resolved
Hide resolved
alextran1502
requested review from
zackpollard,
jrasm91,
danieldietzler and
michelheusschen
web/src/lib/components/photos-page/actions/remove-from-album.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/components/photos-page/actions/remove-from-shared-link.svelte
Outdated
Show resolved
Hide resolved
jrasm91
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a method
dialogController.show({})to programmatically show the confirmation controller without putting it in the template.This PR also refactors the components and pages that are using
<ConfirmationDialog/>in a simple way to this new implementation. There are more complex use of<ConfirmationDialog>with complex nested elements that will be refactored in the future PR.