test: reorder tests in asset.e2e-spec.ts #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorders some tests in prep for later a later PR that will re-use the POST createAsset api method to be run in a loop with the replaceAsset api method.
This moves the POST tests to the end of the file, since we need to rerun setup on a clean db for every loop. This also broke the map-marker tests, since they were using assets created earlier in the suite - so we create a new setup method for those test that just upload the tests.
finally, move some of the for loops that define tests to use it.each() which is just a tiny bit nicer.