feat(server): user metadata #9650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
866366b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b7dd8464.immich.pages.dev |
| Branch Preview URL: | https://feat-user-preferences.immich.pages.dev |
jrasm91
force-pushed
the
feat/user-preferences
branch
from
fbd1e85 to
1509b1e
Compare
jrasm91
force-pushed
the
feat/user-preferences
branch
from
1509b1e to
3af2ad3
Compare
danieldietzler
approved these changes
May 21, 2024
server/src/services/user.service.ts
Outdated
| key: UserMetadataKey.PREFERENCES, | ||
| value: { memories: { enabled: false } }, | ||
| }); | ||
| delete dto.memoriesEnabled; |
There was a problem hiding this comment.
Why do you delete it from the dto?
There was a problem hiding this comment.
So it doesn't get passed to the database
jrasm91
force-pushed
the
feat/user-preferences
branch
from
8edfc67 to
72f8df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for user preferences via a generic user key/value store. User preferences without dedicated database columns makes it significantly easier to add settings, features, and preferences that should be stored per user. Maybe of the user settings in the web application are stored client-side, but could be migrated here in the future.
Additionally, the generic key/value store per user may come into play with plugins, who could get access to per user persistance/settings via this table as well.
Preferences included in this PR:
Preferences to be added in the future: