fix(web): render failed upload buttons correctly on mobile #9601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-barch
changed the title
danieldietzler
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9055.
Before → After
The buttons were overflowing down because their container is set to
h-fulland its closest parent with a defined height is 400px:I fixed it by setting the max height of the row with the thumbnail, progress/status bar, and failed upload buttons to 70px:
I think hardcoding this value is okay because the thumbnail is already hardcoded to a height of 65px plus 2px padding on all sides, and I believe everything in that row is intended to be the same height as the thumbnail.
I also made some minor changes to the Tailwind for the buttons. The borders in the last two screenshots were just for debugging and are not present in this PR. Let me know of any feedback.