-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add archive shortcut to grid #9499
Conversation
Not sure if the keyboard shortcut modal is actually supposed to appear globally since some of the actions don't apply in all contexts ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well.
Need to merge main in again but I'm wondering.. is this superseded by #9712? |
Probably, but this one works and doesn't have any conflicts. That one has a bunch and other unresolved comments, so I'm just going to merge it. |
Closes #9466.
Per the keyboard shortcut modal,
Shift
+A
now works on the grid.