fix(web): always use websocket transport #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4a92cf6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d435862.immich.pages.dev |
| Branch Preview URL: | https://fix-web-no-polling.immich.pages.dev |
|
What about configuring it to try websocket first, but still allow fallback to polling? |
|
I don't think that will fix the issue for multi server environments. |
It should work fine if websockets are supported, right? If the polling fallback is triggered then it could indeed cause issues (but the alternative is that it will just straight up not work). |
bo0tzz
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4611 by always using the websocket transport. This change no longer falls backs to
polling, which requires a sticky session implementation (webserver proxy) to work in multi-server environments.