feat(web): increase map max zoom #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also take a look at the maxZoom in the app? |
Done. |
|
@bo0tzz didn't we say 14 should be the max because the map provider does not support a higher max zoom? |
Map provider obviously supports 18 as you can see from pictures. 14 is not enought to set a gps location. |
|
The provider only supports 14 (although they're pushing out 15 soon). However since they're vector maps, you can still keep zooming beyond that, there just won't be any extra detail. That caused a bit of confusion in the past which is why the zoom level was limited to 14 before. |
jrasm91
approved these changes
Dec 14, 2023
bo0tzz
approved these changes
Dec 14, 2023
danieldietzler
approved these changes
Dec 14, 2023
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
* increate max zoom * increase max zoom on mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases max zoom of the map, to be able see detail location and mainly set gps location to an asset precisely.