fix(mobile): simplify state management in backup selection page #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ec1580a
|
| Status: | ⚡️ Build in progress... |
shenlong-tanwen
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
If this is to improve the forever loading issue in the album selection page, can we also add additional log to the refresh device album method as well?
i.e, update this to log this message and also log the size of availableAlbums from the same method to actually know the number of albums stored in the app state
jonhnet
pushed a commit
to jonhnet/immich
that referenced
this pull request
Dec 15, 2023
…ch-app#5655) * fix(mobile): simplify album selection backup state management * remove search bar' * log available albums
Gigahawk
added a commit
to Gigahawk/immich
that referenced
this pull request
Mar 21, 2024
…ge (immich-app#5655)" This reverts commit 885eba2.
3 tasks
|
Could the search bar be added back in? It would be quite handy dealing with #6164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily remove the search bar in album selection for backup page to simplify the state management aspect