-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle livePhotos using originFileWithSubType #5602
Conversation
20f2b7d
to
99e3c67
Compare
The latest changes somehow caused the MOV portion to be uploaded as an image and the server wasn't able to generate thumbnails or perform other processes on it |
99e3c67
to
70c4c38
Compare
Fixed. Thank you! The The image file name: "IMG_2211.HEIC" The video file name: Also, I've verified upload and download of a live photo available locally. Can you test if the same works for a live photo directly from iCloud? Need to confirm that the following actually returns the video file as well immich/mobile/lib/modules/backup/services/backup.service.dart Lines 275 to 277 in 70c4c38
|
70c4c38
to
7b92d32
Compare
* fix: handle livePhotos using originFileWithSubType * remove livePhoto asset cache * fetch live photo video name from entity * fix: video file not detected * chore: pull main * fix: set correct header --------- Co-authored-by: shenlong-tanwen <[email protected]> Co-authored-by: Alex <[email protected]>
Changes made:
originFileWithSubtype
isLocallyAvailable
now checks for the existence of theoriginFile