Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web+server): showing assets without thumbnail #2652

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

michelheusschen
Copy link
Contributor

#2561 added support for showing assets without thumbnails, but some edge cases were missed:

  1. When a bucket only contains assets without thumbnails, the bucket won't be returned by /asset/count-by-time-bucket and won't show up in the timeline
  2. If you archive an asset without thumbnail, the asset will be become hidden

Fixed by adding withoutThumbnails to these endpoints and showing assets without thumbnails on the archive and favorites page

@vercel
Copy link

vercel bot commented Jun 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Jun 3, 2023 8:21am

alextran1502

This comment was marked as off-topic.

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment for a different PR :P

@alextran1502 alextran1502 merged commit cab5477 into main Jun 4, 2023
@alextran1502 alextran1502 deleted the fix/assets-without-thumbnail branch June 4, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants